chore: Add primary key constraints for TPC-H, TPC-DS#22646
Open
neilconway wants to merge 2 commits into
Open
Conversation
Dandandan
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The TPC-DS and TPC-H specifications define primary keys, but we previously did not include those constraints when defining the TPC-DS and TPC-H schemas. Including the constraints enables the query optimizer to generate better plans (e.g., by leveraging FDs); it also makes the benchmark setup closer to a realistic TPC-DS/H benchmark run.
To enable this, we need to fix
MemTable::load:MemTablecould be constructedwith_constraints, but those constraints were not attached to the table returned byMemTable::load.There is some duplication here: we define two copies of the primary keys of both TPC-DS and TPC-H, because
benchmarksandtest-utilscan't easily share code. This could be improved but I'll defer that for now.What changes are included in this PR?
MemTable::loadto include constraints on the newly loaded tableMemTable::loadto usecollect_partitionedMemTable::loadbehaviorbenchmarkstest-utilsAre these changes tested?
New tests added for
MemTable::loadconstraint behavior. SLT fixtures updated for change in TPC schemas and plans.Are there any user-facing changes?
No.